Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set user id when it's set to empty string #7402

Merged
merged 1 commit into from Mar 11, 2015

Conversation

Projects
None yet
2 participants
@mattab
Copy link
Member

mattab commented Mar 10, 2015

... or it would set the same visitor id to all those visitors

Fixes #7368

Fixes #7368 - Do not set user id when it's set to empty string or it …
…would set the same visitor id to all those visitors

@mattab mattab added this to the Piwik 2.12.0 milestone Mar 10, 2015

mattab pushed a commit that referenced this pull request Mar 11, 2015

Matthieu Aubry
Merge pull request #7402 from piwik/7368
Do not set user id when it's set to empty string

@mattab mattab merged commit 3db2044 into master Mar 11, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@mnapoli mnapoli deleted the 7368 branch Mar 11, 2015

@Sija

This comment has been minimized.

Copy link
Contributor

Sija commented Mar 23, 2015

In my use case user logs in (#setUserId('<user login>')) and logs out (#setUserId(undefined)), but because of this PR, the second call is silently dropped without changing userId. How can I clear, once set userId?

@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Mar 23, 2015

Hi @Sija That's a great question, can you please create a new issue here? we will add the possibility to setUserId with false or something similar (to reset the user id)

@Sija

This comment has been minimized.

Copy link
Contributor

Sija commented Mar 24, 2015

Sure, I've made a PR #7518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.