Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rename columns twice when aggregating dataTable records #7435

Merged
merged 1 commit into from Mar 16, 2015

Conversation

@tsteur
Copy link
Member

tsteur commented Mar 16, 2015

refs #4768

We can assume that columns are already renamed if we have already renamed all columns of all dataTables in a map.

This saves 50-200ms when aggregating records (eg when range date is requested) per record. Depending on the dataTables can save even way more time or a bit less.

I just did some profiling on the demo database where the performance benefit is > 1 second (out of 26 seconds total time)

mattab pushed a commit that referenced this pull request Mar 16, 2015
…nce_tweak

Do not rename columns twice when aggregating dataTable records
@mattab mattab merged commit 0bbc42c into master Mar 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tsteur tsteur deleted the aggregateDataTableRecord_performance_tweak branch Mar 16, 2015
@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Mar 16, 2015

FYI: I just had a case where this saves like 60 seconds (out of 360 seconds total time)

@mattab mattab added the answered label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.