Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller website manager table to fit in smaller screens #7510

Merged
merged 1 commit into from Mar 25, 2015

Conversation

@mnapoli
Copy link
Contributor

mnapoli commented Mar 23, 2015

The website manager is pretty large and doesn't fit in small screens (even my 13" laptop).

While waiting for the admin redesign in #7492 I simply merged "Edit" and "Delete" (like in the proposed redesign) into a single column.

It's not a full fix but it improves the current situation a little bit.

Before

capture d ecran 2015-03-23 a 16 48 33

After

capture d ecran 2015-03-23 a 16 46 12

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Mar 25, 2015

Looks good to me. I'll merge it and adjust the UI tests

sgiehl added a commit that referenced this pull request Mar 25, 2015
Smaller website manager table to fit in smaller screens
@sgiehl sgiehl merged commit d29c949 into master Mar 25, 2015
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Scrutinizer No new issues
Details
@sgiehl sgiehl deleted the smaller-website-table branch Mar 25, 2015
@fvdm

This comment has been minimized.

Copy link

fvdm commented Mar 30, 2015

How about also remove the Edit/Delete text and add a new icon for the javascript tracking code?

@plastikschnitzer

This comment has been minimized.

Copy link

plastikschnitzer commented Mar 31, 2015

How about removing white-space:nowrap; from the class ".entityTable tr th" in css? This will break table head lables, saving a lot of space in my case (German translation)

@mnapoli

This comment has been minimized.

Copy link
Contributor Author

mnapoli commented Mar 31, 2015

@plastikschnitzer sounds like a good idea, would you have time to submit a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.