Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with success -> successfully #7936

Merged
merged 1 commit into from May 20, 2015
Merged

with success -> successfully #7936

merged 1 commit into from May 20, 2015

Conversation

@dandv
Copy link
Contributor

dandv commented May 19, 2015

No description provided.

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented May 19, 2015

Before merging that, we should consider, that it would erase all translations available for this two keys - even if the sense stays the same, so I wouldn't see much benefit in doing it.

@mnapoli

This comment has been minimized.

Copy link
Contributor

mnapoli commented May 19, 2015

@sgiehl what is the correct way to edit an english translation if we don't want to loose other translations?

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented May 19, 2015

We would need to readd them on transifex after the source was updated

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented May 19, 2015

If we decide to merge that. We should do it right after the next release. Then I have enough time to do the required changes on transifex

@mattab

This comment has been minimized.

Copy link
Member

mattab commented May 19, 2015

Apparently with success is incorrect english, so +1 to merge it

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented May 20, 2015

OK. Then I'll do that. @mattab When will the next release be published?

@sgiehl sgiehl self-assigned this May 20, 2015
@mattab

This comment has been minimized.

Copy link
Member

mattab commented May 20, 2015

When all issues in 2.14.0 are closed: https://github.com/piwik/piwik/milestones/2.14.0 - maybe 2 weeks or bit more?

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented May 20, 2015

OK. Then I'll do it before

sgiehl pushed a commit that referenced this pull request May 20, 2015
Stefan Giehl
with success -> successfully
@sgiehl sgiehl merged commit 2b9eea0 into matomo-org:master May 20, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.