Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kartograph 0.8.2 #8283

Merged
merged 1 commit into from Jul 12, 2015

Conversation

@barbushin
Copy link
Contributor

barbushin commented Jul 6, 2015

Fixes #8243

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Jul 6, 2015

Nice, I thought about that last time but didn't think it would be that easy to upgrade Kartograph lib 👍 It's quite a big version jump considering that it is 0.X.X. We should probably test quite a bit whether everything still works? Do you know if there was changed a lot? Maybe it'd be better to include it in 2.14.1?

@barbushin

This comment has been minimized.

Copy link
Contributor Author

barbushin commented Jul 6, 2015

I compared Piwik on Kartograph 0.8.2 with Piwik on Kartograph that was in master, and it looks like there is no difference how they works. But, anyway, it will be better if we do more tests, because I'm not so big expert in Piwik maps use cases :)

@mattab mattab added this to the 2.14.1 milestone Jul 7, 2015
mattab pushed a commit that referenced this pull request Jul 12, 2015
Update to Kartograph 0.8.2
@mattab mattab merged commit 0ae2508 into master Jul 12, 2015
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Scrutinizer No new issues
Details
@mattab

This comment has been minimized.

Copy link
Member

mattab commented Jul 12, 2015

Looks good to me!

@mattab mattab deleted the 8243_map_nan_error branch Jul 12, 2015
@mattab mattab restored the 8243_map_nan_error branch Jul 12, 2015
@mattab

This comment has been minimized.

Copy link
Member

mattab commented Jul 12, 2015

It seems the real time maps regressed, @barbushin can you reproduce this? let me know if not, cheers

@mattab mattab deleted the 8243_map_nan_error branch Jul 13, 2015
@mattab mattab restored the 8243_map_nan_error branch Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.