Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config to set email name in email FROM field #8454

Merged
merged 2 commits into from Jul 31, 2015

Conversation

Projects
None yet
2 participants
@tsteur
Copy link
Member

tsteur commented Jul 29, 2015

fixes #8252

tsteur added some commits Jul 29, 2015

@tsteur tsteur added the Needs Review label Jul 29, 2015

@tsteur tsteur added this to the 2.15.0 milestone Jul 29, 2015

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Jul 30, 2015

LGTM. Should we maybe mention that in the changelog?

@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Jul 31, 2015

Not sure which changelog you're referring too :) I think it should not appear in the developer changelog as it is rather a user thing to conifgure it. The original issue should appear in the changelog though (#8252). I will edit the title and to something like "New config to set email name in email FROM field"

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Jul 31, 2015

Ok, then good to merge ;)

tsteur added a commit that referenced this pull request Jul 31, 2015

Merge pull request #8454 from piwik/8252
Added config to set email name in email FROM field

@tsteur tsteur merged commit 9626cc5 into master Jul 31, 2015

1 of 3 checks passed

Scrutinizer Timed out
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tsteur tsteur deleted the 8252 branch Jul 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.