New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display total number of actions across all websites #8550

Merged
merged 3 commits into from Aug 13, 2015

Conversation

Projects
None yet
4 participants
@mnapoli
Contributor

mnapoli commented Aug 11, 2015

Fixes #8288

Show the total number of actions in the header:

capture d ecran 2015-08-12 a 10 31 41

I had to change the translation key TotalVisitsPageviewsRevenue to TotalVisitsPageviewsActionsRevenue, is it worth mentioning it in the changelog?

@mnapoli mnapoli added the Enhancement label Aug 11, 2015

@mnapoli mnapoli added this to the 2.15.0 milestone Aug 11, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 12, 2015

Member

Was the issue only about adding total number of actions and later, in another issue, let people customize the dashboard so that they can add actions if needed? I'm not sure if I understood the issue right. Actions itself doesn't seem like a high value metric there (but in some cases it can be more value than pageviews)

Member

tsteur commented Aug 12, 2015

Was the issue only about adding total number of actions and later, in another issue, let people customize the dashboard so that they can add actions if needed? I'm not sure if I understood the issue right. Actions itself doesn't seem like a high value metric there (but in some cases it can be more value than pageviews)

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Aug 12, 2015

Contributor

I went with the quick fix, see #8288 (comment)

This is really high value for us, so targetting for 2.15.0 - we will need to find a solution, either a quick fix (display the number somewhere in the UI), or the more complicated - but terribly awesome - feature of letting users customise columns on All Websites dashboard: #2390

Contributor

mnapoli commented Aug 12, 2015

I went with the quick fix, see #8288 (comment)

This is really high value for us, so targetting for 2.15.0 - we will need to find a solution, either a quick fix (display the number somewhere in the UI), or the more complicated - but terribly awesome - feature of letting users customise columns on All Websites dashboard: #2390

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 12, 2015

Member

(display the number somewhere in the UI)

I think it's only meant the total number but not sure. @mattab ?

Member

tsteur commented Aug 12, 2015

(display the number somewhere in the UI)

I think it's only meant the total number but not sure. @mattab ?

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 12, 2015

Member

Maybe we don't really need the new column in the dashboard and we could only display the total number at the top?

Member

mattab commented Aug 12, 2015

Maybe we don't really need the new column in the dashboard and we could only display the total number at the top?

@quba

This comment has been minimized.

Show comment
Hide comment
@quba

quba Aug 12, 2015

Contributor

Total number should suffice for now. But ability to customise would be really useful as well.

Contributor

quba commented Aug 12, 2015

Total number should suffice for now. But ability to customise would be really useful as well.

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Aug 12, 2015

Contributor

I've updated the PR (and the screenshot above) to remove the "Actions" column. I'll try to look at customizable columns, hopefully this is easy. In the meantime I think it shouldn't block this PR.

Contributor

mnapoli commented Aug 12, 2015

I've updated the PR (and the screenshot above) to remove the "Actions" column. I'll try to look at customizable columns, hopefully this is easy. In the meantime I think it shouldn't block this PR.

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 12, 2015

Member

Re customizing columns: I'm not sure if it will be done in config or so but it would be nice if it was possible to configure it per site or my measurable type (website, mobile app, car, ...) one day. It might be not yet needed but in the future might be useful to think about it (eg how it could be displayed when different sites want to show different metrics etc). Use case: A B2B website has different relevant metrics than a B2C shop than a car than a mobile app

Member

tsteur commented Aug 12, 2015

Re customizing columns: I'm not sure if it will be done in config or so but it would be nice if it was possible to configure it per site or my measurable type (website, mobile app, car, ...) one day. It might be not yet needed but in the future might be useful to think about it (eg how it could be displayed when different sites want to show different metrics etc). Use case: A B2B website has different relevant metrics than a B2C shop than a car than a mobile app

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 13, 2015

Member

Can this one be merged?

Member

tsteur commented Aug 13, 2015

Can this one be merged?

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 13, 2015

Member

There's no "needs review". Looks good otherwise

Member

tsteur commented Aug 13, 2015

There's no "needs review". Looks good otherwise

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 13, 2015

Member

Very nice!

Member

mattab commented Aug 13, 2015

Very nice!

mattab pushed a commit that referenced this pull request Aug 13, 2015

Matthieu Aubry
Merge pull request #8550 from piwik/8288
Display total number of actions across all websites

@mattab mattab merged commit 539a619 into master Aug 13, 2015

0 of 3 checks passed

Scrutinizer Errored
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@mnapoli mnapoli deleted the 8288 branch Aug 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment