New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and fixes to the archive purging system #8559

Merged
merged 2 commits into from Aug 20, 2015

Conversation

Projects
None yet
2 participants
@diosmosis
Member

diosmosis commented Aug 12, 2015

Contains two fixes for the archive purging system:

  1. For purging invalidated archives, includes an extra group by in the GROUP_CONCAT query used to find invalidated archives that can be purged. By grouping by name too, we get less idarchives per row, which means the GROUP_CONCAT limit should not be hit.

  2. Fixes a regression where the purgeOutdatedArchives task was skipped because it could no longer tell if it was executed during the core:archive command (since it does not use CliMulti anymore). Includes two new (light) tests for this use case.

Refs #7181 (should fix it, but will need confirmation)

diosmosis added some commits Aug 12, 2015

Make sure purgeOutdatedArchives task is executed in scheduled task ru…
…n after core:archive run (regression caused by scheduled task execution refactor).

@diosmosis diosmosis added the Bug label Aug 12, 2015

@diosmosis diosmosis added this to the 2.15.0 milestone Aug 12, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 12, 2015

Member

Nice find! hopefully this will fix #7181

LGTM

Member

mattab commented Aug 12, 2015

Nice find! hopefully this will fix #7181

LGTM

@mattab mattab added the Needs Review label Aug 17, 2015

diosmosis added a commit that referenced this pull request Aug 20, 2015

Merge pull request #8559 from piwik/archive_purging_fixes
Fixes #7181, make sure GROUP_CONCAT does not cut off results when purging invalidated archives, and fix regression in purging temporary archive where core:archive execution was not detected.

@diosmosis diosmosis merged commit 87b4877 into master Aug 20, 2015

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@diosmosis diosmosis deleted the archive_purging_fixes branch Aug 20, 2015

@mattab mattab changed the title from Two more fixes to archive purging system to Improvements and fixes to the archive purging system Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment