New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ONLY_FULL_GROUP_BY Mysql mode when creating connection #8589

Merged
merged 3 commits into from Aug 21, 2015

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Aug 18, 2015

refs #5124

Workaround for Piwik not being compatible with mysql mode ONLY_FULL_GROUP_BY. Idea is to disable it until we have a proper solution (being compatible) for it.

I'm not sure re the SQL modes that we set but was recommended by a user in #5124 (comment) and sounds reasonable. We could make it configurable but would prefer to do this only when needed.

@tsteur tsteur added this to the 2.15.0 milestone Aug 18, 2015

@tsteur tsteur changed the title from Disable ONLY_FULL_GROUP_BY Mysql mode when creating an instance to Disable ONLY_FULL_GROUP_BY Mysql mode when creating connection Aug 18, 2015

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 20, 2015

Member

Will a proper solution be implemented for 3.0? If so, perhaps #5124 should be put into the 3.0 milestone.

CC @mattab

Member

diosmosis commented Aug 20, 2015

Will a proper solution be implemented for 3.0? If so, perhaps #5124 should be put into the 3.0 milestone.

CC @mattab

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 20, 2015

Member

Instead of setting the whole SQL mode, would it be a better solution to replace the existing SQL mode via a method like http://johnemb.blogspot.com/2014/09/adding-or-removing-individual-sql-modes.html ?

Member

diosmosis commented Aug 20, 2015

Instead of setting the whole SQL mode, would it be a better solution to replace the existing SQL mode via a method like http://johnemb.blogspot.com/2014/09/adding-or-removing-individual-sql-modes.html ?

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 21, 2015

Member

It would be a bit slower to do this on each request and I'd prefer to set the same SQL mode on each instance unless there's a problem. This way we - hopefully - won't have any weird bug reports that are hard to debug and caused by a different SQL mode. It should make our life easier and more predictable.

I don't think that it will be implemented for 3.0 but rather somewhen later.

Member

tsteur commented Aug 21, 2015

It would be a bit slower to do this on each request and I'd prefer to set the same SQL mode on each instance unless there's a problem. This way we - hopefully - won't have any weird bug reports that are hard to debug and caused by a different SQL mode. It should make our life easier and more predictable.

I don't think that it will be implemented for 3.0 but rather somewhen later.

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 21, 2015

Member

I think this would likely result in less bug reports anyway, so I think this is a good idea for LTS. In fact, maybe enforcing as strict an SQL mode as possible would be a good idea (in the long run)? Anyway, will merge this PR.

Member

diosmosis commented Aug 21, 2015

I think this would likely result in less bug reports anyway, so I think this is a good idea for LTS. In fact, maybe enforcing as strict an SQL mode as possible would be a good idea (in the long run)? Anyway, will merge this PR.

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 21, 2015

Member

Ok, there are some system test failures; I restarted the build, if it passes I'll merge.

Member

diosmosis commented Aug 21, 2015

Ok, there are some system test failures; I restarted the build, if it passes I'll merge.

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 21, 2015

Member

Test failures appear to be in master, rebased myself.

Member

diosmosis commented Aug 21, 2015

Test failures appear to be in master, rebased myself.

diosmosis added a commit that referenced this pull request Aug 21, 2015

Merge pull request #8589 from piwik/5124
Refs #5124, for 2.15 LTS, disable ONLY_FULL_GROUP_BY Mysql mode when creating connection by using explicitly specified SQL mode. May be removed in 3.0.

@diosmosis diosmosis merged commit 3d20b1e into master Aug 21, 2015

0 of 3 checks passed

Scrutinizer Created
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@diosmosis diosmosis deleted the 5124 branch Aug 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment