New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always take the minimum number of custom variables from all log tables instead of maximum #8662

Merged
merged 1 commit into from Aug 30, 2015

Conversation

Projects
None yet
3 participants
@tsteur
Member

tsteur commented Aug 29, 2015

fixes #8555

I checked Piwik and PiwikPRO plugins and couldn't find any usages of getMaxCustomVariables. Added some tests to make sure it works as expected and also did some manual tests of the info and set-max-custom-variables command on top of the automated tests. Should work as expected.

@tsteur tsteur added this to the 2.15.0 milestone Aug 29, 2015

diosmosis added a commit that referenced this pull request Aug 30, 2015

Merge pull request #8662 from piwik/8555
Fixes #8555, always use the minimum number of custom variables from all log tables instead of maximum so Piwik won't fail when tables are in inconsistent state.

@diosmosis diosmosis merged commit 061190b into master Aug 30, 2015

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Scrutinizer 1 updated code elements
Details

@diosmosis diosmosis deleted the 8555 branch Aug 30, 2015

@mattab mattab added Task and removed not-in-changelog labels Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment