New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to add query parameters to optout form #8666

Merged
merged 5 commits into from Sep 11, 2015

Conversation

Projects
None yet
3 participants
@Zeichen32
Contributor

Zeichen32 commented Aug 30, 2015

This PR allows plugins to add query parameters to the optout form.
This is necessary for example to add the "siteid" parameter.

@tsteur

View changes

Show outdated Hide outdated plugins/CoreAdminHome/OptOutManager.php
@tsteur

View changes

Show outdated Hide outdated plugins/CoreAdminHome/OptOutManager.php
@tsteur

View changes

Show outdated Hide outdated plugins/CoreAdminHome/OptOutManager.php
@tsteur

View changes

Show outdated Hide outdated plugins/CoreAdminHome/templates/optOut.twig
@Zeichen32

This comment has been minimized.

Show comment
Hide comment
@Zeichen32

Zeichen32 Sep 10, 2015

Contributor

I have rebase the brache and added the feature again 👍

Contributor

Zeichen32 commented Sep 10, 2015

I have rebase the brache and added the feature again 👍

*/
public function removeQueryParameter($key)
{
unset($this->queryParameters[$key]);

This comment has been minimized.

@tsteur

tsteur Sep 11, 2015

Member

Do you mind just adding a little check if array_key_exists($key, $this->queryParameters)? Just to prevent a possible notice. Afterwards it should be good to merge :)

@tsteur

tsteur Sep 11, 2015

Member

Do you mind just adding a little check if array_key_exists($key, $this->queryParameters)? Just to prevent a possible notice. Afterwards it should be good to merge :)

This comment has been minimized.

@Zeichen32

Zeichen32 Sep 11, 2015

Contributor

Its not necessary, because unset throws no notice if array element does not exists.

@Zeichen32

Zeichen32 Sep 11, 2015

Contributor

Its not necessary, because unset throws no notice if array element does not exists.

This comment has been minimized.

@tsteur

tsteur Sep 11, 2015

Member

Sweet, did not know that. Thx!

@tsteur

tsteur Sep 11, 2015

Member

Sweet, did not know that. Thx!

tsteur added a commit that referenced this pull request Sep 11, 2015

Merge pull request #8666 from Zeichen32/OptOutManagerQueryParameters
Allow plugins to add query parameters to optout form

@tsteur tsteur merged commit a52b7f9 into matomo-org:master Sep 11, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer 1 new issues, 4 updated code elements
Details

@tsteur tsteur added this to the 2.15.0 milestone Sep 11, 2015

@mattab mattab removed the Enhancement label Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment