New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions in ScheduledReports generation so reports will still generate if individual reports fail #8726

Merged
merged 4 commits into from Sep 11, 2015

Conversation

Projects
None yet
2 participants
@diosmosis
Member

diosmosis commented Sep 7, 2015

As title. Includes test + some checks in RowEvolution to avoid unexpected fatal errors. (This happened to one user, but it seems there was no easy way to debug the issue.)

@diosmosis diosmosis self-assigned this Sep 7, 2015

@diosmosis diosmosis added this to the 2.15.0 milestone Sep 7, 2015

diosmosis added some commits Sep 5, 2015

Catch exceptions when getting individual reports during scheduled rep…
…orts generation so reports will still be sent even if individual reports fail in some way.
Add test for ScheduledReports API.generateReport exception catching. …
…Includes making Proxy constructor public (for mocking) and using Common::sendHeader in ReportRenderer (so headers won't be sent twice).
@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 11, 2015

Member

Very nice and 👍 for adding that integration test

Member

mattab commented Sep 11, 2015

Very nice and 👍 for adding that integration test

mattab pushed a commit that referenced this pull request Sep 11, 2015

Matthieu Aubry
Merge pull request #8726 from piwik/scheduled_reports_catch
Catch exceptions in ScheduledReports generation so reports will still generate if individual reports fail

@mattab mattab merged commit deedaed into master Sep 11, 2015

3 checks passed

Scrutinizer 3 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mattab mattab deleted the scheduled_reports_catch branch Sep 11, 2015

@mattab mattab added the Bug label Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment