Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Additional events in archiving lifecycle #8738
I created this PR, because sometimes we need to inject into archiving lifecycle, especially we want to detect when archiving was started and finished. I added two additional events (look at changes). Please review this: Maybe should I pass more arguments into those events ? Maybe then it would be more useful ?
Maybe we can rename the events to
Regarding parameters: I'd find it awesome to only post the current instance of
To still have access to the timer you could either create a
A tiny little documentation re this event would be nice see https://github.com/piwik/piwik/blob/2.15.0-b5/core/CronArchive.php#L313-L319 but we can also add it ourselves.
@tsteur I made your suggestion.
I need only inject into start and the end of archiving (sometimes is very useful). Mentioned by you $this as event argument, sounds more flexible.