Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging messages in core:archive output #8777

Merged
merged 3 commits into from Sep 14, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Sep 14, 2015

  • made output more consistent and easier to read by a human
  • better summary report for "Skipped websites" stats

 * made output more consistent and easier to read by a human
 * better summary report for "Skipped websites" stats
@mattab mattab added the Needs Review PRs that need a code review label Sep 14, 2015
@mattab mattab added this to the 2.15.0 milestone Sep 14, 2015
Skipped 0 websites
- Skipped 0 websites: no new visit since the last script execution
- Skipped 0 websites: existing daily reports are less than 150 seconds old
- Skipped 0 websites: existing week/month/year periods reports are less than 3600 seconds old
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of repeating Skipped 0 websites, would it be clearer to do something like:

Skipped 0 websites:
- 0 skipped because there were no new visits since last script execution
- 0 skipped because existing daily reports are less than 150 seconds old
- 0 skipped because existing week/month/year period reoprts are less than 3600 seconds old

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, done in 39e34ed

mattab pushed a commit that referenced this pull request Sep 14, 2015
Better logging messages in core:archive output
@mattab mattab merged commit 60061cc into master Sep 14, 2015
@diosmosis diosmosis deleted the core_archive_better_log_messages branch September 14, 2015 04:46
dhoko pushed a commit to dhoko/piwik that referenced this pull request Sep 14, 2015
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants