New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use less functions in gradient mixins to avoid lessphp failures #8919

Merged
merged 1 commit into from Oct 5, 2015

Conversation

Projects
None yet
2 participants
@diosmosis
Member

diosmosis commented Oct 5, 2015

Do not use less functions in gradient mixins to avoid lessphp failures when the color values are not actual color values

Failures can occur when the color values are, for example, placeholders.

Affects one pro plugin.

Do not use less functions in gradient mixins to avoid lessc failures …
…when the color values are not actual color values (eg, they could be placeholders).

@diosmosis diosmosis added this to the 2.15.0 milestone Oct 5, 2015

mattab pushed a commit that referenced this pull request Oct 5, 2015

Matthieu Aubry
Merge pull request #8919 from piwik/gradient_less_bug
Do not use less functions in gradient mixins to avoid lessphp failures when the color values are not actual color values

@mattab mattab merged commit a678ae0 into master Oct 5, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@mattab mattab deleted the gradient_less_bug branch Oct 5, 2015

@mattab mattab changed the title from Do not use less functions in gradient mixins to avoid lessphp failures when the color values are not actual color values to Do not use less functions in gradient mixins to avoid lessphp failures Oct 13, 2015

@mattab mattab removed the c: Design / UI label Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment