New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add backwards compatibility for URLs using old UserSettings plugin. #8941

Merged
merged 3 commits into from Oct 8, 2015

Conversation

Projects
None yet
3 participants
@diosmosis
Member

diosmosis commented Oct 7, 2015

As title. Includes system tests so BC break will be detected in the future. And includes tweaks to UI tests for more coverage.

Fixes #8923

@diosmosis diosmosis added this to the 2.15.0 milestone Oct 7, 2015

@mattab

View changes

Show outdated Hide outdated core/testMinimumPhpVersion.php
@@ -49,4 +50,33 @@ public function extendVisitorDetails(&$visitor, $details)
$visitor['browserVersion'] = $instance->getBrowserVersion();
}
public function renameUserSettingsModuleAndAction(&$module, &$action)

This comment has been minimized.

@tsteur

tsteur Oct 8, 2015

Member

Can we remove it again in Piwik 3.0 maybe? We could add a reminder to remove it in DeprecatedMethodsTest

@tsteur

tsteur Oct 8, 2015

Member

Can we remove it again in Piwik 3.0 maybe? We could add a reminder to remove it in DeprecatedMethodsTest

This comment has been minimized.

@diosmosis

diosmosis Oct 8, 2015

Member

Added to DeprecatedMethodsTest.

@diosmosis

diosmosis Oct 8, 2015

Member

Added to DeprecatedMethodsTest.

diosmosis added some commits Oct 7, 2015

Re-add backwards compatibility for URLs using old UserSettings plugin…
… + add test coverage so BC break will be detected in the future.
Add new renameUserSettingsModuleAndAction event handlers to Deprecate…
…dMethodsTest so they will be removed in 3.0.
@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Oct 8, 2015

Member

Ready for another review/merge.

Member

diosmosis commented Oct 8, 2015

Ready for another review/merge.

mattab pushed a commit that referenced this pull request Oct 8, 2015

Matthieu Aubry
Merge pull request #8941 from piwik/8923_usersettings_bc
Re-add backwards compatibility for URLs using old UserSettings plugin.

@mattab mattab merged commit 4432578 into master Oct 8, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@mattab mattab deleted the 8923_usersettings_bc branch Oct 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment