Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude unneeded files/folders from git packages #9434

Merged
merged 1 commit into from Sep 21, 2016

Conversation

Projects
None yet
3 participants
@sgiehl
Copy link
Member

sgiehl commented Dec 22, 2015

replaces #9406

@sgiehl sgiehl added the Needs Review label Dec 22, 2015

@sgiehl sgiehl added this to the 3.0.0-b1 milestone Dec 22, 2015

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Dec 23, 2015

Should we maybe add some more from here: https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh#L111 ? Some people seem to download ZIP from Github and this way it would contain similar content to the actual build.zip. Or maybe we would not even need it in the build-package anymore? That would be ideal

@sgiehl

This comment has been minimized.

Copy link
Member Author

sgiehl commented Dec 26, 2015

Sure, we could include some more files for exclusion, but I'm unsure which files....
But as long as the build-package doesn't use a git archive the files needs to be removed there aswell.



# Files excluded from git packages
tests/ export-ignore

This comment has been minimized.

Copy link
@tsteur

tsteur Aug 30, 2016

Member

For some reasons we also allow to have tests in Test directory which we should remove as well if these paths apply to nested directories as well? or do they only apply to directories in root directory? Maybe we need to define /tests or something similar to .gitignore?

This comment has been minimized.

Copy link
@tsteur

tsteur Aug 30, 2016

Member

does it automatically remove .git folder?

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Aug 30, 2016

Added a comment re absolute paths but otherwise seems ok to merge.

FYI: This also affects zip downloads on github. I presume we want to remove it from there as well so it's 👍 but mentioning it just in case we want to let users download everything from there @mattab

We certainly should create a follow up issue re https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh#L111 so we have a unified logic there and the definitions only in one place.

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Sep 1, 2016

FYI: The branch points to 3.0 but should be now 3.x-dev

@sgiehl sgiehl changed the base branch from 3.0 to 3.x-dev Sep 2, 2016

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Sep 20, 2016

Hi @sgiehl - could you resolve the merge conflict? Then Looks good to merge

@sgiehl sgiehl force-pushed the excludefrompackage branch from 4812888 to 6ccfbcc Sep 20, 2016

@sgiehl

This comment has been minimized.

Copy link
Member Author

sgiehl commented Sep 20, 2016

rebased it on latest 3.x-dev branch.

@mattab mattab merged commit 1f10b64 into 3.x-dev Sep 21, 2016

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@mattab mattab deleted the excludefrompackage branch Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.