New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Segmented Visitor Log" icon to more reports and subtables #9478

Merged
merged 2 commits into from Jan 12, 2016

Conversation

Projects
None yet
3 participants
@sgiehl
Copy link
Member

sgiehl commented Jan 5, 2016

  • Adds "Segmented Visitor Log" icon to various reports and subtables (fixes #7213)
    • keywords > search engine
    • search engines > keyword
    • websites > wensite url
    • social networks > social network url
    • referrer type
  • Adds new segment for devices brand (refs #7212)

fixes #9501

@sgiehl sgiehl force-pushed the 7213 branch from 78dac94 Jan 6, 2016

@sgiehl sgiehl added Needs Review and removed Pull Request WIP labels Jan 6, 2016

@sgiehl sgiehl force-pushed the 7213 branch 2 times, most recently to fe1d3b5 Jan 6, 2016

@@ -1,7 +1,279 @@
<?xml version="1.0" encoding="utf-8" ?>
<results>
<result idSite="1">
<result date="2010-01-03" />
<result date="2010-01-03">

This comment has been minimized.

@tsteur

tsteur Jan 10, 2016

Member

I think you might need to modify https://github.com/piwik/piwik/blob/2.16.0-b1/tests/PHPUnit/System/TwoVisitsWithCustomVariablesSegmentMatchNONETest.php#L58-L77 and maybe add a special case so it doesn't match anything?

This comment has been minimized.

@sgiehl

sgiehl Jan 11, 2016

Member

Good point. I'll try to adjust that.

@sgiehl sgiehl force-pushed the 7213 branch 5 times, most recently to 67e540b Jan 11, 2016

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Jan 11, 2016

PR looks good! Can you maybe squash the commits and then merge? If not a direct merge should be ok too

@tsteur tsteur added this to the 2.16.0 milestone Jan 11, 2016

@tsteur tsteur referenced this pull request Jan 12, 2016

Closed

New segment DeviceBrand #9501

@sgiehl sgiehl force-pushed the 7213 branch from 67e540b to 8f3ac40 Jan 12, 2016

sgiehl added a commit that referenced this pull request Jan 12, 2016

Merge pull request #9478 from piwik/7213
Adds "Segmented Visitor Log" icon to more reports and subtables

@sgiehl sgiehl merged commit 3f8c476 into master Jan 12, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@sgiehl sgiehl deleted the 7213 branch Jan 12, 2016

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8" ?>
<result>
<row>Unknown</row>

This comment has been minimized.

@mattab

mattab Jan 12, 2016

Member

@sgiehl would it be possible to have this test generate real values so it shows that the auto suggest for this new segment works as expected?

This comment has been minimized.

@sgiehl

sgiehl Jan 13, 2016

Member

I'll issue a pull request for that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment