Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website chooser may not work because of a whitespace problem #9712

Merged
merged 1 commit into from Feb 4, 2016

Conversation

@tsteur tsteur added the Needs Review label Feb 4, 2016
@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Feb 4, 2016

Looks good.

sgiehl added a commit that referenced this pull request Feb 4, 2016
Website chooser may not work because of a whitespace problem
@sgiehl sgiehl merged commit 083b4ce into master Feb 4, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sgiehl sgiehl deleted the websitechooser_whitespace branch Feb 4, 2016
@mattab

This comment has been minimized.

Copy link
Member

mattab commented Feb 5, 2016

@tsteur @sgiehl Maybe we can add a ReleaseChecklistTest integration test that looks for these "problematic" spaces in all JS files (and more as appropriate), so we can detect before the release, preventing this issue occuring again?

@SebaldJ

This comment has been minimized.

Copy link

SebaldJ commented Feb 7, 2016

Hello,
i have a smiliar Bug with the Version 2.16.0:
On the Dashboard, the Website chooser shows this html code:
{{'CoreHome_ChangeCurrentWebsite' |translate: ((selectedSite.name ||))}} {{(Â model.firstSiteName) |htmldecode)}}

More on the Piwik Forum:
http://forum.piwik.org/t/bug-after-update-to-piwik-2-16-0-dashboard-select-websites/17920/2

But, even after adding patch of space or the the whole line, has nothing changed, the error is still present.

Is there a workaround or bug fix?
I am grateful of any help.

Greets John

@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Feb 7, 2016

You might need to clear the browser cache afterwards

@SebaldJ

This comment has been minimized.

Copy link

SebaldJ commented Feb 7, 2016

Hello tsteur,
the problem is unfortunately still present even after emptying the browser cache in Chrome.

tsteur added a commit to matomo-org/plugin-AnonymousPiwikUsageMeasurement that referenced this pull request Feb 7, 2016
tsteur added a commit to matomo-org/plugin-CustomDimensions that referenced this pull request Feb 7, 2016
tsteur added a commit that referenced this pull request Feb 7, 2016
@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Feb 7, 2016

@mattab that should be possible. Maybe need to limit to html, twig and .php and js files without our files. Eg there are actually expected test files etc with this character (meaning our test DB may contain this whitespace)

@tsteur tsteur mentioned this pull request Feb 7, 2016
@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Feb 7, 2016

@SebaldJ please try to apply this patch as well https://github.com/piwik/piwik/pull/9729/files

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Feb 8, 2016

New integration test to catch this problem pro-actively in the future #9730

@SebaldJ

This comment has been minimized.

Copy link

SebaldJ commented Feb 8, 2016

@tsteur The Patch from https://github.com/piwik/piwik/pull/9729/files works fine!
I have changed the following files:

plugins/CoreHome/angularjs/siteselector/siteselector.directive.html (line 19 and 40)
plugins/ScheduledReports/API.php (line 736)

The bug is gone. Thank your for your help

@BSG2000

This comment has been minimized.

Copy link

BSG2000 commented Feb 8, 2016

@tsteur I was also successful - same patch as @SebaldJ .
Thank you for support!

@mattab mattab added the Bug label Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.