Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piwik.js: remove the feature of `setDomains` that sets cookie path #9933

Merged
merged 1 commit into from Mar 30, 2016

Conversation

Projects
None yet
2 participants
@mattab
Copy link
Member

commented Mar 16, 2016

Instead, we will better document how to correctly set the cookie configuration.

Todo

  • Regenerate compiled piwik.js

Refs #9932

@mattab mattab added the Needs Review label Mar 16, 2016

@mattab mattab added this to the 2.16.1 milestone Mar 16, 2016

@mattab mattab changed the title piwik.js: remove the feature of `setDomains` magically setting the cookie path piwik.js: remove the feature of `setDomains` that sets cookie path Mar 16, 2016

@tsteur

This comment has been minimized.

Copy link
Member

commented Mar 29, 2016

@mattab I pushed compiled piwik.js . Feel free to merge. Should it be in changelog?

piwik.js: remove the feature of `setDomains` magically setting the co…
…okie path.

Instead, we will better document how to correctly set the cookie configuration. #9932

@mattab mattab force-pushed the remove_magic_setCookiePath branch from dde4c6a to 3ff659d Mar 30, 2016

@mattab mattab merged commit 7a894b7 into master Mar 30, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

mattab pushed a commit that referenced this pull request Mar 30, 2016

@mattab mattab deleted the remove_magic_setCookiePath branch Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.