Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set returning visitor flag when user first visited the website at least 1 day ago #9942

Merged
merged 2 commits into from Mar 30, 2016

Conversation

Projects
None yet
3 participants
@mattab
Copy link
Member

mattab commented Mar 17, 2016

As a result, we will assign "Returning visitor" flag slightly more often. This will lead to better data accuracy.

While editing this FAQ http://piwik.org/faq/general/faq_21418/ this bug somehow became visible.

@mattab mattab added the Needs Review label Mar 17, 2016

@mattab mattab added this to the 2.16.1 milestone Mar 17, 2016

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Mar 21, 2016

LGTM

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Mar 29, 2016

LGTM as well. @mattab have you had a look at the failing system tests? https://travis-ci.org/piwik/piwik/jobs/116619093 I can fix them in the branch before merging if ok

@mattab mattab merged commit 045ca76 into master Mar 30, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@mattab mattab deleted the use_days_since_first_visit branch Mar 30, 2016

@mattab mattab added the Enhancement label Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.