New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VWO tag #64

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
3 participants
@MichaelHeerklotz
Contributor

MichaelHeerklotz commented Aug 24, 2018

No description provided.

@Findus23

Thanks for another tag.

I haven't tested it, but it should work.

Show resolved Hide resolved Template/Tag/VisualWebsiteOptimizerTag.web.js Outdated
Show resolved Hide resolved images/icons/visualwebsitepptimizer.svg Outdated
Show resolved Hide resolved Template/Tag/VisualWebsiteOptimizerTag.web.js Outdated
Show resolved Hide resolved lang/en.json Outdated
@@ -480,6 +480,9 @@
"VisibleElementTextVariableName": "Visible Element Text",
"VisibleElementUrlVariableDescription": "The value of the link URL (href) of an element that was matched when the visible element trigger was triggered.",
"VisibleElementUrlVariableName": "Visible Element Destination URL",
"VisualWebsiteOptimizerTagDescription": "Visual Website Optimizer is a all-in-one A/B testing and Conversion Optimization Platform.",
"VisualWebsiteOptimizerTagHelp": "This tag adds the asynchronous VWO Smart Code to your website.",
"VisualWebsiteOptimizerTagName": "Visual Website Optimizer",

This comment has been minimized.

@Findus23

Findus23 Aug 25, 2018

Member

Do you think the name should be translated?

This comment has been minimized.

@MichaelHeerklotz

MichaelHeerklotz Oct 17, 2018

Contributor

I am not sure how to supply a name with spaces without this translation. Is there a way to do it?

This comment has been minimized.

@Findus23

Findus23 Oct 17, 2018

Member

Hi,

You can do it like this:

public function getName() {
return "Tawk.to";
}

@tsteur

This comment has been minimized.

Member

tsteur commented Oct 8, 2018

@MichaelHeerklotz are you still working on this? Can I be of any help to make changes or is it considered done?

Michael Heerklotz

@MichaelHeerklotz MichaelHeerklotz force-pushed the MichaelHeerklotz:tag_vwo branch from 3b93601 to 721b8e3 Oct 17, 2018

@MichaelHeerklotz

This comment has been minimized.

Contributor

MichaelHeerklotz commented Oct 17, 2018

Thank you for your feedback and help, I have updated my commit.

@tsteur tsteur merged commit 3172d06 into matomo-org:master Nov 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment