New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Emarsys tag #65

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
3 participants
@MichaelHeerklotz
Contributor

MichaelHeerklotz commented Aug 24, 2018

Basic Emarsys support, currently with these commands: category, view, tag, go
Use case: landing pages or similar that supplement a given shop system

@Findus23

Hi,

While I haven't tested it, the tag looks good.

The image can be replaced with

<svg xmlns="http://www.w3.org/2000/svg" height="36.8" width="25.5" viewBox="0 0 25.5 36.8">
    <!-- Source: https://www.emarsys.com/app/uploads/2018/05/ema_web_logos_2018_01_0-1.zip (cropped) -->
    <path transform="translate(-22.8)" fill="#40877e" d="M22.8 17v-5.7L35.5 17v5.7z"/>
    <path transform="translate(-22.8)" fill="#32d17e" d="M22.8 11.3L48.2 0v5.7L22.8 17z"/>
    <path transform="translate(-22.8)" fill="#d9e506" d="M48.2 17v-5.7L35.5 17v5.7z"/>
    <path transform="translate(-22.8)" fill="#6984d1" d="M48.2 28.4v-5.7l-19 8.5v5.7z"/>
</svg>
);
}
public function getOrder()

This comment has been minimized.

@Findus23

Findus23 Aug 25, 2018

Member

Until we have a significant number of different tags, I'd leave the default order and maybe order all of them afterwards.

@tsteur

This comment has been minimized.

Member

tsteur commented Oct 8, 2018

@MichaelHeerklotz are you still working on this? Can I be of any help to make changes or is it considered done?

Michael Heerklotz

@MichaelHeerklotz MichaelHeerklotz force-pushed the MichaelHeerklotz:tag_emarsys branch from 6972bf2 to 5373245 Oct 17, 2018

@MichaelHeerklotz

This comment has been minimized.

Contributor

MichaelHeerklotz commented Oct 17, 2018

Thank you for your feedback and help, I have applied the changes.

@tsteur tsteur merged commit f3fd8d7 into matomo-org:master Nov 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment