New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Piwik tracking server is down/unavailable, piwik.php should fail gracefuly, not 505 #8

Closed
MagicFab opened this Issue Sep 17, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@MagicFab

MagicFab commented Sep 17, 2015

If the Piwik tracking server becomes unavailable, under normal implementation (using the standard .js tracker code), it's invoked and if it fails/is unavailable, there is no impact to the site / page being loaded. It will just not track stats anymore.

Using the tracker proxy, a 505 error is returned which in turn makes the site being tracked also return such error.

The tracker-proxy code for this is ~line 78, this should fail gracefuly instead of making the main site being tracked completely unavailable.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 17, 2015

Member

Hi @MagicFab

Using the tracker proxy, a 505 error is returned which in turn makes the site being tracked also return such error.

Do you have a screenshot or more information regarding the error triggered on the website?

Member

mattab commented Sep 17, 2015

Hi @MagicFab

Using the tracker proxy, a 505 error is returned which in turn makes the site being tracked also return such error.

Do you have a screenshot or more information regarding the error triggered on the website?

@MagicFab

This comment has been minimized.

Show comment
Hide comment
@MagicFab

MagicFab Sep 17, 2015

No at the moment, this would require bringing down the content this was originally observed on, which is currently under consideration. I started creating an environment to reproduce this but haven't finished yet.

MagicFab commented Sep 17, 2015

No at the moment, this would require bringing down the content this was originally observed on, which is currently under consideration. I started creating an environment to reproduce this but haven't finished yet.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 17, 2015

Member

re-opening, as we need to add automated tests to make sure we don't regress in the future

Member

mattab commented Sep 17, 2015

re-opening, as we need to add automated tests to make sure we don't regress in the future

@mattab mattab reopened this Sep 17, 2015

@MagicFab

This comment has been minimized.

Show comment
Hide comment
@MagicFab

MagicFab Sep 17, 2015

I've confirmed this fixes the issue as originally reported - thank you!

MagicFab commented Sep 17, 2015

I've confirmed this fixes the issue as originally reported - thank you!

@MagicFab MagicFab closed this Sep 17, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 17, 2015

Member

Good news @MagicFab

re-opening, as we need to add automated tests to make sure we don't regress in the future

Member

mattab commented Sep 17, 2015

Good news @MagicFab

re-opening, as we need to add automated tests to make sure we don't regress in the future

@mattab mattab reopened this Sep 17, 2015

@mattab mattab closed this in f67de00 Sep 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment