Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #57

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Removing php-5.3 test because this PHP version is so old that this is hard to do test.
  • The shell_exec is not appropriate. Using the rename function instead.
  • To support latest stable PHPUnit version, using the final 4.8.36 version to be easy to migrate future PHPUnit version.
  • Using the PHPUnit\Framework\TestCase class to be compatible with future PHPUnit version.
  • The dirname(__FILE__) is equivalent to the __DIR__. Using the __DIR__ instead.

@tsteur tsteur merged commit c7cfdb5 into matomo-org:master Nov 7, 2019
@peter279k peter279k deleted the test_enhancement branch November 8, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants