doc/mpl_examples/pylab_examples/transoffset.py not working as expected #1084

Closed
pelson opened this Issue Aug 14, 2012 · 4 comments

Projects

None yet

2 participants

@pelson
Matplotlib Developers member

The example doc/mpl_examples/pylab_examples/transoffset.py is no longer functioning as expected.

Probably related to a change I have made somewhere down the line...

@pelson pelson was assigned Aug 14, 2012
@mdboom
Matplotlib Developers member

If you don't know about it already, maybe try git bisect to locate the issue.

@pelson
Matplotlib Developers member

If you don't know about it already, maybe try git bisect to locate the issue.

git bisect is genius! There is no denying who the culprit is though:

git bisect bad
37e3851ec451a4d63ba03bfde84c070999b6ab3f is the first bad commit
commit 37e3851ec451a4d63ba03bfde84c070999b6ab3f
Author: Phil Elson <philipelson@...>
Date:   Wed Jun 6 10:04:56 2012 +0100

    Squashed class_projections from #694

:040000 040000 03818447b07d962fd1bf8eb0ef9a53ddfb4bd520 8dd82752f973e46de2b28e7292858ef1a58ae208 M  doc
:040000 040000 a358bf4ac6cae395ef73a045a9bd5476d08dac7f c0f1f8e1e993a492eb8d82d0dfcd6d67f2275456 M  lib
@mdboom
Matplotlib Developers member

Cool. Again this shows that our test coverage isn't so great. Maybe add a unit test based on transoffset.py to make sure this doesn't regress again in the future?

@pelson
Matplotlib Developers member

Yes I was intending to do just that, as it seems like one of those features that is broadly useful, yet untested.

@pelson pelson closed this Aug 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment