MacOS backend modifier keys #1259

Closed
pelson opened this Issue Sep 15, 2012 · 8 comments

Comments

Projects
None yet
4 participants
Member

pelson commented Sep 15, 2012

The MacOS backend does not currently have modifier key support such as that available in TkAgg, GtkAgg, WxAgg, QT4Agg etc.

A simple test: Create a figure and try hitting ctrl+w

Note: Follows on from #851.

Member

dmcdougall commented Sep 16, 2012

I've been looking into this. The problem is the FigureCanvasMac class does not implement functions such as key_press_event, like the GTK backend does. My initial assessment is that this, although would be nice to have, will take a little time. It probably shouldn't stop the release candidate, but it should make it into a bugfix release, perhaps.

Member

pelson commented Sep 17, 2012

It probably shouldn't stop the release candidate, but it should make it into a bugfix release, perhaps.

There is no urgency on this IMHO. It is a thing that we would love to have done, but ultimately, will only get done if somebody really needs it (and is motivated to do it!). Personally, I wouldn't be concerned if this didn't get in until 1.3.

Contributor

mdehoon commented Dec 12, 2012

key_press_event for FigureCanvasMac is implemented in in the C code in _macosx.m in the keyDown method. Probably it's not difficult to add modifiers to it. Any volunteers?

Member

dmcdougall commented Dec 12, 2012

I started a local branch for this and never got round to finishing it. I'm happy to volunteer to do it, but I'd like to get some of my current pull requests completed before creating more unfinished pieces of work.

Member

dmcdougall commented Dec 14, 2012

(Please don't let that prevent anybody else from writing a patch. I can't find my branch anyway!)

Contributor

cimarronm commented Mar 22, 2013

Added a patch for this in #1841

Member

dmcdougall commented Mar 27, 2013

#1841 merged; closing.

dmcdougall closed this Mar 27, 2013

Member

pelson commented Mar 27, 2013

Wooho thanks @cimarronm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment