Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

MacOS backend modifier keys #1259

Closed
pelson opened this Issue · 8 comments

4 participants

@pelson
Collaborator

The MacOS backend does not currently have modifier key support such as that available in TkAgg, GtkAgg, WxAgg, QT4Agg etc.

A simple test: Create a figure and try hitting ctrl+w

Note: Follows on from #851.

@dmcdougall
Collaborator

I've been looking into this. The problem is the FigureCanvasMac class does not implement functions such as key_press_event, like the GTK backend does. My initial assessment is that this, although would be nice to have, will take a little time. It probably shouldn't stop the release candidate, but it should make it into a bugfix release, perhaps.

@pelson
Collaborator

It probably shouldn't stop the release candidate, but it should make it into a bugfix release, perhaps.

There is no urgency on this IMHO. It is a thing that we would love to have done, but ultimately, will only get done if somebody really needs it (and is motivated to do it!). Personally, I wouldn't be concerned if this didn't get in until 1.3.

@mdehoon

key_press_event for FigureCanvasMac is implemented in in the C code in _macosx.m in the keyDown method. Probably it's not difficult to add modifiers to it. Any volunteers?

@dmcdougall
Collaborator

I started a local branch for this and never got round to finishing it. I'm happy to volunteer to do it, but I'd like to get some of my current pull requests completed before creating more unfinished pieces of work.

@dmcdougall
Collaborator

(Please don't let that prevent anybody else from writing a patch. I can't find my branch anyway!)

@cimarronm
Collaborator

Added a patch for this in #1841

@dmcdougall
Collaborator

#1841 merged; closing.

@dmcdougall dmcdougall closed this
@pelson
Collaborator

Wooho thanks @cimarronm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.