Skip to content
This repository

Undefined elements in axes module #1465

Closed
NelleV opened this Issue November 08, 2012 · 3 comments

3 participants

Varoquaux Eric Firing Phil Elson
Varoquaux
Collaborator

Dixit pyflakes, there are several undefined elements in the axes module:

  • The method Axes.__pick (line 3240) calls test, which isn't defined
  • The method Axes.dist (line 3221) calls Patch and Text which haven't been imported

Thanks,
N

Phil Elson
Collaborator

I've labelled these as bugs. It may be that there are no code paths to trigger them, in which case, we can just remove the code.

Thanks for raising @NelleV .

Varoquaux
Collaborator

I still don't know what to do here: I tend to think that as the code does not work since 2006, we should probably remove it (less code to maintain is always a good thing).

Maybe @efiring, being the author of this code, can comment on this.

Eric Firing
Owner

Rip out the entire __pick() method. Everything down to the "### Labelling" comment. The sooner the better. I don't know how it survived so long--probably because axes.py is so huge that obsolete junk like this can hide in it for years.

I'm not actually the author of this; I come up with "blame" because of a fairly large reorganization of axes.py that I did long ago--basically shuffling things around so that I could find things.

Varoquaux NelleV referenced this issue from a commit December 06, 2012
Commit has since been removed from the repository and is no longer available.
Eric Firing efiring closed this in 4652560 December 06, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.