Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging debug of loaded modules #21978

Closed
kkwaiser opened this issue Dec 16, 2021 · 1 comment · Fixed by #21980
Closed

Remove logging debug of loaded modules #21978

kkwaiser opened this issue Dec 16, 2021 · 1 comment · Fixed by #21980
Labels
Good first issue Open a pull request against these issues if there are no active ones!
Milestone

Comments

@kkwaiser
Copy link

Hi there,

Would you be willing to remove this debug statement from the init.py file? It leads to excessive logging output. In my case, it is printing the name of ~1800 modules and really crowding out more valuable debug statements. Thanks!

_log.debug('loaded modules: %s', list(sys.modules))

@tacaswell
Copy link
Member

A version of that log statement has been there from 2004 so I am wary of removing it. This also seems like it is problem that can / should be solved on the consumer side.

On the other hand, I am not sure what the actual value of that log is (as it is not specific to Matplotlib) and came in the svn days via c3b1103 with the comment "add zorder" which seems unrelated. I also think it got swept up as part of the mass move from our custom logging -> standard logging without a lot of consideration.

In the process of writing this I managed to talk myself from be weakly against removing it to being weakly in favor of removing it.

Because it is a change of a long standing behavior it will need a note in the API changes, but no deprecation period. Labeling as good first issue is it is removing 1 line + writing a sentence documenting that it was removed.

@tacaswell tacaswell added this to the v3.6.0 milestone Dec 16, 2021
@tacaswell tacaswell added the Good first issue Open a pull request against these issues if there are no active ones! label Dec 16, 2021
@QuLogic QuLogic changed the title Remove loggin debug of loaded modules Remove logging debug of loaded modules Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Open a pull request against these issues if there are no active ones!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants