patch for qt4 backend #238

Closed
ddale opened this Issue Jun 20, 2011 · 5 comments

Comments

Projects
None yet
5 participants
@ddale
Contributor

ddale commented Jun 20, 2011

Original report at SourceForge, opened Thu Apr 14 15:29:33 2011

I want to propose a patch for matplotlib-1.0.1 fixing some bugs in the qt4 backend + minor changes

backend_qt4.py
-) inheritance bug in NaviagtionToolbar2QT
calling QtGui.QToolBar.init( ) before NavigationToolbar2.init( ) causes that self cannot be used as parent for QFileDialog ( funciton save_figure)
-) subplottool creates its own MainWindow --> leaving Dialog open even if the plot is closed -> made Dialog modal
-) proposal for a slightly altererd funciton edit_parameters. Instead of repr(axes) it uses "Axes_%d" to make the choises more human readable

figureoptions.py
-) attribute COLOR redifines mpl-default colors slighty differend (e.g. 'y': '#bfbf00', vs 'y': '#ffff00')
-) funciton col2hex can now handle rgb, hex and mpl-default colors

SourceForge History

  • On Thu Apr 14 15:30:31 2011, by rhoef: File Added: 408749: qt4backend.patch

@ghost ghost assigned ddale Jun 20, 2011

@taldcroft

This comment has been minimized.

Show comment Hide comment
@taldcroft

taldcroft Mar 26, 2012

I'm seeing a problem with the save figure dialog using the Qt backend on linux x86_64 (Python 2.7, matplotlib 1.1.0, Qt 4.8, Centos-5). After pressing the GUI save button the dialog box opens for a flash and then closes. I'm wondering if my problem is related to this issue or if I should report it separately. Has this patch been applied in any dev branch?

I'm seeing a problem with the save figure dialog using the Qt backend on linux x86_64 (Python 2.7, matplotlib 1.1.0, Qt 4.8, Centos-5). After pressing the GUI save button the dialog box opens for a flash and then closes. I'm wondering if my problem is related to this issue or if I should report it separately. Has this patch been applied in any dev branch?

@fheday

This comment has been minimized.

Show comment Hide comment
@fheday

fheday Apr 20, 2012

The same behaviour in macos x Lion (Python 2.7.2, matplotlib 1.1.0, Qt 4.7.4+quartz, macports)

fheday commented Apr 20, 2012

The same behaviour in macos x Lion (Python 2.7.2, matplotlib 1.1.0, Qt 4.7.4+quartz, macports)

@fheday

This comment has been minimized.

Show comment Hide comment
@fheday

fheday Apr 20, 2012

How do I download/apply your patch?

fheday commented Apr 20, 2012

How do I download/apply your patch?

@pelson

This comment has been minimized.

Show comment Hide comment
@pelson

pelson Aug 21, 2012

Member

@mdboom: I don't see any activity on this issue. The original issue sounds like (a very reasonable) feature request. The subsequent issue by @taldcroft sounds like a bug report (unconfirmed as I can press the save button successfully on master [osx 10.8, python2.7, PyQt4.QtCore.PYQT_VERSION_STR: '4.9.2']).

I suggest this is moved out of 1.2.x, a new issue is opened for @taldcroft's bug and is put under the milestone 1.2.x known bugs once it is confirmed on master. Thoughts?

Member

pelson commented Aug 21, 2012

@mdboom: I don't see any activity on this issue. The original issue sounds like (a very reasonable) feature request. The subsequent issue by @taldcroft sounds like a bug report (unconfirmed as I can press the save button successfully on master [osx 10.8, python2.7, PyQt4.QtCore.PYQT_VERSION_STR: '4.9.2']).

I suggest this is moved out of 1.2.x, a new issue is opened for @taldcroft's bug and is put under the milestone 1.2.x known bugs once it is confirmed on master. Thoughts?

@mdboom

This comment has been minimized.

Show comment Hide comment
@mdboom

mdboom Aug 21, 2012

Member

I can't reproduce @taldcroft's bug either, but I think it is not related to this issue. @taldcroft: If you're still seeing your problem with the save dialog, can you file a new issue?

I think we should close this issue -- we don't have access to the patch, and it's a bunch of unrelated things tied together in any case -- I don't think it has much hope of getting in without being separated out anyway.

Member

mdboom commented Aug 21, 2012

I can't reproduce @taldcroft's bug either, but I think it is not related to this issue. @taldcroft: If you're still seeing your problem with the save dialog, can you file a new issue?

I think we should close this issue -- we don't have access to the patch, and it's a bunch of unrelated things tied together in any case -- I don't think it has much hope of getting in without being separated out anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment