Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

undocumented scatter marker definition change #547

Closed
ghost opened this Issue · 7 comments

3 participants

Michael Droettboom Phil Elson Eric Firing
Deleted user

The definition of scatter marker via (numsides,style,angle) has been changed in this pull. Now the angle should be specified in degrees, as opposed to radians in the earlier version.
This breaks backward-compatibility and should be noted explicitly in the docstring here.

Michael Droettboom
Owner

See my response here:

mdboom@243d78d#commitcomment-666981

Deleted user

Hi Michael
Thanks a lot for the prompt response!

Michael Droettboom
Owner

You're welcome -- I want to get some feedback from other developers about whether we should stick with radians or move to degrees and I'll either update the code or the docs accordingly.

Phil Elson
Collaborator

@mdboom : Shall we raise the issue on the mailing list, or simply update the api-changelog?

Eric Firing
Owner

@mdboom, @pelson, sorry I did not chime in 11 months ago, but I agree with Phil's comments at that time; most people, including me, will find degrees more natural and easy to use for things like this.

Phil Elson
Collaborator

On that basis, do we need to go through the rest of the mpl api and replace radians with degrees throughout?

Eric Firing
Owner

A little grepping suggests that the majority of angle specifications are now either degrees or can be given in either degrees or radians. An example of one that is in radians is patches.RegularPolygon, which has an "orientation" kwarg in radians. Probably the thing to do there is add a new kwarg, like "degrees_ccw" or "ccw_degrees", and deprecate the old one. This could be left for 1.3.

Michael Droettboom mdboom closed this in 43dc729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.