Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`cleanup` decorator implemented in an obfuscated way #6716

Closed
Kojoley opened this issue Jul 9, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@Kojoley
Copy link
Member

commented Jul 9, 2016

It seems to be that this line should be before make_cleanup(style) call.

@QuLogic

This comment has been minimized.

Copy link
Member

commented Jul 9, 2016

I think that line is not necessary, according to the comment above the function.

@Kojoley

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2016

Yeah, I have just realized it too.

@Kojoley

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2016

Is not style = 'classic' assignment edits make_cleanup closure variable? Then it cannot be removed.

@QuLogic

This comment has been minimized.

Copy link
Member

commented Jul 9, 2016

Yea, I guess I should have read the whole thing; it probably could do with another comment...

@Kojoley

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2016

I think it is better to rewrite it in some cleaner way...

@Kojoley Kojoley changed the title Possible bug in `cleanup` decorator `cleanup` decorator implemented in an obfuscated way Jul 9, 2016

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 10, 2016

@tacaswell

This comment has been minimized.

Copy link
Member

commented Jul 10, 2016

And do so with an eye towards playing nice with pytest. I have been loving fixtures on other projects, but not sure how to apply them to this.

Maybe pass in a properly prepared matplotlib module as a fixture?

@tacaswell tacaswell added the Testing label Jul 10, 2016

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Oct 3, 2017

@anntzer

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2018

Should we just deprecate it now that everything moved to pytest (and style choice is provided by a pytest marker)?

@tacaswell

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

A lot of down-stream packaging use our testing code for their own projects, we should just let this sit for a few more years until nose fully dies.

I am going to close this as no-action. This code is working, no need to change it as we are no longer using it and no need to risk breaking anyone down-stream.

@tacaswell tacaswell closed this Jan 12, 2018

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.