Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which image formats to build in docs. #6835

Closed
jenshnielsen opened this issue Jul 26, 2016 · 5 comments
Closed

Which image formats to build in docs. #6835

jenshnielsen opened this issue Jul 26, 2016 · 5 comments
Assignees
Milestone

Comments

@jenshnielsen
Copy link
Member

When I did #6823 and changed the dpi I did not remember that we had merged #5677
which changed the default HTML docs to build svg examples rather than pdf examples. Apparently #5677 was not backported to 2.x

There are several questions.

  • Should the change to use SVG's be backported?
  • The svg's are build with a dpi of 72? Why? Should that not match the default dpi?
@jenshnielsen jenshnielsen added this to the 2.0 (style change major release) milestone Jul 26, 2016
@efiring
Copy link
Member

efiring commented Jul 26, 2016

The discussion on #5677 noted that the backport needed to await checking of the svg results. My first random check, http://matplotlib.org/devdocs/examples/lines_bars_and_markers/scatter_with_legend.html, shows a problem. Notice that the legend is plotting the symbol twice with slightly different sizes in the svg, but not in the png.
Conclusion: the necessary review of the svg output probably has not been done. I think that some comparisons of rendering time between svg and pdf is also needed. In the example above, the svg seems rather slow, much slower than the original pdf here: http://matplotlib.org/examples/lines_bars_and_markers/scatter_with_legend.html.

Overall, at this point I suspect that switching to svg is just going to make more work and degraded performance. The only benefit is sharper plots in the web page, compared to the present png.

@QuLogic
Copy link
Member

QuLogic commented Jul 27, 2016

On the axisartist page, several axis lines appear to be too thick. This may be an SVG renderer issue. For example, see SVG vs. PNG where the left line appears correct, but the right line is a bit thicker.

@QuLogic
Copy link
Member

QuLogic commented Jul 27, 2016

The pcolor images have that unfortunate edge thing that shows up in PDFs, which I don't think is a great thing to show by default.

@efiring
Copy link
Member

efiring commented Jul 27, 2016

On 2016/07/25 10:39 PM, Jens Hedegaard Nielsen wrote:

There are several questions.

  • Should the change to use SVG's be backported?

I think the answer is a clear "No!" I'm inclined to recommend reverting
the change in master--maybe after taking advantage of the temporary
change to find problems in the svg backend. Overall, I don't think svg
is a very useful format. It's not as fast and reliable in web pages as
png, and there aren't many applications in which one can use it.

@jenshnielsen
Copy link
Member Author

Implemented in #6862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants