Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt backend figureoptions.py does not work due to change in image.py #9332

Closed
bastianbeischer opened this issue Oct 9, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@bastianbeischer
Copy link

commented Oct 9, 2017

Bug report

Bug summary

Clicking on the figure options button (only available in the Qt backend) when showing an image does not work anymore. The dialog does not open and the script throws a TypeError.

Code for reproduction

from matplotlib import use
use('Qt5Agg')

import numpy as np
import matplotlib.pyplot as plt

data = np.ones((10,10))

plt.figure()
plt.imshow(data)
plt.show()

Click on figure options button (the second one from the right).

Actual outcome

Figure options dialog is not shown, instead a TypeError is thrown:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/matplotlib/backends/backend_qt5.py", line 681, in edit_parameters
    figureoptions.figure_edit(axes, self)
  File "/usr/lib/python2.7/site-packages/matplotlib/backends/qt_editor/figureoptions.py", line 168, in figure_edit
    + [(name, name) for name in sorted(image.iterpnames)])]
TypeError: 'instancemethod' object is not iterable

Expected outcome

Figure options dialog is opened and the script does not throw the TypeError. Used to work in matplot 2.0.2.

Matplotlib version

Bug introduced in matplotlib 2.1.0, specifcally this commit:

6ee70cb

changes 'iterpnames' from a variable (which is iterable) into a function (which must be called). The callside (figureoptions.py) was not modified accordingly. I guess adding '()' after iterpnames in figureoptions.py line 168 fixes the problem (untested).

@dstansby dstansby added this to the 2.1.1 (next bug fix release) milestone Oct 9, 2017

@anntzer anntzer referenced this issue Oct 9, 2017

Merged

Fix poorly done deprecations in image.py. #9335

0 of 6 tasks complete
@anntzer

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

Sorry... xref #9335.

@tacaswell

This comment has been minimized.

Copy link
Member

commented Oct 21, 2017

Closed by #9335

Thanks for taking the time to report this @bastianbeischer !

@tacaswell tacaswell closed this Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.