pcolormesh edgecolor of "None" #999

Closed
pelson opened this Issue Jul 10, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@pelson
Member

pelson commented Jul 10, 2012

#901 implemented a direct check that the edgecolor was not "None", but this excludes the use of "none" (or any other case derivative):

import numpy
import matplotlib.pyplot as plt

plt.subplot(121)
plt.pcolormesh(numpy.arange(12).reshape(3, 4), edgecolors='none')
plt.subplot(122)
plt.pcolormesh(numpy.arange(12).reshape(3, 4), edgecolors='None')
plt.show()

Please consider implementing case insensitive equivalent behaviour.

@mdboom

This comment has been minimized.

Show comment Hide comment
@mdboom

mdboom Jul 10, 2012

Owner

I don't think #901 introduced this -- it removed a check (which was case sensitive) and allowed it to pass through to another part of the library (which is also case sensitive). I'm not sure I consider this a bug -- most things in matplotlib are case sensitive.

Owner

mdboom commented Jul 10, 2012

I don't think #901 introduced this -- it removed a check (which was case sensitive) and allowed it to pass through to another part of the library (which is also case sensitive). I'm not sure I consider this a bug -- most things in matplotlib are case sensitive.

@efiring

This comment has been minimized.

Show comment Hide comment
@efiring

efiring Jul 15, 2012

Owner

The relevant code appears to be in Collection.set_edgecolor, which converts everything to lower case. Although in general I prefer case-sensitivity, there are exceptions, and this is one; it is just too hard to remember that something should be "None", and something else should be "none". So, as far as I can see, things are working in a reasonable fashion.

Owner

efiring commented Jul 15, 2012

The relevant code appears to be in Collection.set_edgecolor, which converts everything to lower case. Although in general I prefer case-sensitivity, there are exceptions, and this is one; it is just too hard to remember that something should be "None", and something else should be "none". So, as far as I can see, things are working in a reasonable fashion.

@efiring efiring closed this Jul 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment