Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add version to documentation header #10065
This adds a version number to the header section of the documentation. The motivation is to make it always obvious, which version of the documentation one is using:
Minor header height correction
While working on this, I realized that the header is probably slightly higher than intended (compare the white pixels below the github badge in the current docs).
The reason was a fixed-width logo, which takes slightly too much height (129px instead of 125px). I've changed this for a fixed height. As a result, the logo is slightly smaller, but I assume this is the actually desired layout.
jklymak left a comment
I'd left align. Looks funky for long version numbers.
But otherwise I really like this!
Oops, sorry, I didn't see how you were anchoring. If at all humanly possible I'd anchor below the second "t" or second "l". If thats too hard (sorry my css/html is a bit rusty), what you have is fine. After all folks can expect a few rough edges if they look at the Master version of the docs.
I agree with right alignment, though maybe 0.5 or even 0.25 em lower just to make the dot of the i not overlap the circle.
I don't really think there's any reason for the given header height. When I CSS-ified the GitHub banner, that's just the size that came out of the generator and matched the old image. I'm not sure one or the other is "right" in that regard.