Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: fix line length #10100

Merged
merged 1 commit into from Dec 26, 2017

Conversation

Projects
None yet
5 participants
@tacaswell
Copy link
Member

commented Dec 26, 2017

PR Summary

unbreaks CI on master.

PR Checklist

  • Code is PEP 8 compliant

@tacaswell tacaswell added this to the v2.1.2 milestone Dec 26, 2017

@anntzer

This comment has been minimized.

Copy link
Contributor

commented Dec 26, 2017

thanks

@anntzer anntzer merged commit 355943e into matplotlib:master Dec 26, 2017

8 checks passed

ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 8a1d647...2498898
Details
codecov/project/library 62.83% (target 50%)
Details
codecov/project/tests 98.85% (+0.46%) compared to 8a1d647
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@meeseeksdev

This comment has been minimized.

Copy link

commented Dec 26, 2017

There seem to be a conflict, please backport manually

@dstansby

This comment has been minimized.

Copy link
Contributor

commented Dec 26, 2017

Sorry...

@QuLogic

This comment has been minimized.

Copy link
Member

commented Dec 26, 2017

Backported as part of #10099.

@tacaswell tacaswell deleted the tacaswell:fix_linelength branch Dec 26, 2017

@lkjell

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2017

Sorry, is it 80 char that is max?

@anntzer

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2017

79

@lkjell

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2017

Same for doc as well or 72?

@anntzer

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2017

We use 79 everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.