qt4: remove duplicate file save button; and remove trailing whitespace #1014

Merged
merged 1 commit into from Jul 16, 2012

Conversation

Projects
None yet
2 participants
Owner

efiring commented Jul 15, 2012

No description provided.

Member

pelson commented Jul 16, 2012

Thanks Eric. This is good to go.

The trailing whitespaces have been added by me. In general I am using a combination of PyDev for Eclipse (indigo) and vim (vanilla). How have you got your setup configured to avoid this whitespace junk?

Owner

efiring commented Jul 16, 2012

I use an editor that always removes trailing whitespace upon saving. I may be the only person using this editor: http://currents.soest.hawaii.edu/hgstage/zed/. I have not been able to find any trace of the original author for many years. In any case, most other people seem to use emacs, so our docs include instructions on how to configure it:
http://matplotlib.sourceforge.net/devel/coding_guide.html. For vim I find this: http://vim.wikia.com/wiki/Remove_unwanted_spaces#Automatically_removing_all_trailing_whitespace
and for pydev, this:
http://vim.wikia.com/wiki/Remove_unwanted_spaces#Automatically_removing_all_trailing_whitespace.

If these things work for you, perhaps you would like to make a pull request to add these tips to the coding_guide?

efiring added a commit that referenced this pull request Jul 16, 2012

Merge pull request #1014 from efiring/fix_qt4_icon_dup
qt4: remove duplicate file save button; and remove trailing whitespace

@efiring efiring merged commit 43968f1 into matplotlib:master Jul 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment