Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pandas fixture. #10178

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
3 participants
@anntzer
Copy link
Contributor

commented Jan 6, 2018

PR Summary

Followup to #10124.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
register()
try:
yield pd
finally:
try:
from pandas.plotting import (
deregister_matplotlib_converters as deregister)
request.addfinalizer(deregister)

This comment has been minimized.

Copy link
@QuLogic

QuLogic Jan 6, 2018

Member

Why aren't you just calling it?

This comment has been minimized.

Copy link
@anntzer

anntzer Jan 6, 2018

Author Contributor

because it was a typo (as in, forgot to change that)

@anntzer anntzer force-pushed the anntzer:pandas-fixture branch from 4c594eb to 96da183 Jan 6, 2018

@@ -80,22 +80,21 @@ def mpl_image_comparison_parameters(request, extension):

@pytest.fixture
def pd(request):

This comment has been minimized.

Copy link
@tacaswell

tacaswell Jan 6, 2018

Member

do we still need to take in request?

This comment has been minimized.

Copy link
@anntzer

anntzer Jan 6, 2018

Author Contributor

nope...

@QuLogic

QuLogic approved these changes Jan 6, 2018

@QuLogic QuLogic added the Testing label Jan 6, 2018

@QuLogic QuLogic added this to the v2.2 milestone Jan 6, 2018

@anntzer anntzer force-pushed the anntzer:pandas-fixture branch from 96da183 to 4fa99e3 Jan 6, 2018

@QuLogic QuLogic merged commit 32a67d3 into matplotlib:master Jan 6, 2018

5 checks passed

ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@anntzer anntzer deleted the anntzer:pandas-fixture branch Jan 6, 2018

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.