Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase of #8504 #10180

Merged
merged 2 commits into from Jan 6, 2018
Merged

Rebase of #8504 #10180

merged 2 commits into from Jan 6, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 6, 2018 •
edited

PR Summary

A rebase of #8504, Add tests for external process calls, plus a little cleanup.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v2.2 milestone Jan 6, 2018
@QuLogic
TST: Cleanup new tests a bit.
7cf0e22 
Matplotlib doesn't support pytest Path objects, so convert to str.
Remove unnecessary randomness and fix typos.
@anntzer anntzer merged commit 5c51676 into matplotlib:master Jan 6, 2018
@QuLogic QuLogic deleted the subprocesses branch January 7, 2018 03:13
@QuLogic QuLogic mentioned this pull request Jan 7, 2018
Closed
@anntzer anntzer mentioned this pull request Jan 30, 2018
Merged
6 tasks
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@QuLogic @tacaswell @anntzer @tomspur