Skip to content
This repository

Added 'capthick' kwarg to errorbar() #1031

Merged
merged 4 commits into from over 1 year ago

3 participants

Benjamin Root Michael Droettboom Eric Firing
Benjamin Root
Collaborator

Exactly what it says on the label. Probably should add some examples (or modify existing ones). Tests might be nice too...

Michael Droettboom
Owner

Looks good. I would add or modify a regression test to use capthick so this doesn't get lost in the future. Aside from that, I think this is good to merge.

Benjamin Root
Collaborator

So, looking through the tests, there is only one place where we even bother testing errorbars, and that is in the svg backend tests. Methinks it is time to re-evaluate our coverage strategy...

Michael Droettboom
Owner

You mean develop a coverage strategy... ;)

Michael Droettboom
Owner

BTW - I was suggesting adding a new test for errorbars -- and something in particular that exercises the new capthick feature.

Benjamin Root
Collaborator

Almost ready with the first round of errorbar tests, slightly modified from the examples. Not exactly sure if my version of freetype (or the fonts installed) is yielding good quality baseline png images, though.

Benjamin Root
Collaborator

I think this PR of mine is ready for someone to give their stamp of approval and merge it in.

Eric Firing efiring merged commit d0c501b into from August 17, 2012
Eric Firing efiring closed this August 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.