Added 'capthick' kwarg to errorbar() #1031

Merged
merged 4 commits into from Aug 17, 2012

Conversation

Projects
None yet
3 participants
Member

WeatherGod commented Jul 20, 2012

Exactly what it says on the label. Probably should add some examples (or modify existing ones). Tests might be nice too...

Owner

mdboom commented Aug 3, 2012

Looks good. I would add or modify a regression test to use capthick so this doesn't get lost in the future. Aside from that, I think this is good to merge.

Member

WeatherGod commented Aug 14, 2012

So, looking through the tests, there is only one place where we even bother testing errorbars, and that is in the svg backend tests. Methinks it is time to re-evaluate our coverage strategy...

Owner

mdboom commented Aug 14, 2012

You mean develop a coverage strategy... ;)

Owner

mdboom commented Aug 14, 2012

BTW - I was suggesting adding a new test for errorbars -- and something in particular that exercises the new capthick feature.

Member

WeatherGod commented Aug 14, 2012

Almost ready with the first round of errorbar tests, slightly modified from the examples. Not exactly sure if my version of freetype (or the fonts installed) is yielding good quality baseline png images, though.

Member

WeatherGod commented Aug 17, 2012

I think this PR of mine is ready for someone to give their stamp of approval and merge it in.

efiring added a commit that referenced this pull request Aug 17, 2012

Merge pull request #1031 from WeatherGod/errorbar_capthick
Added 'capthick' kwarg to errorbar()

@efiring efiring merged commit d0c501b into matplotlib:master Aug 17, 2012

@WeatherGod WeatherGod deleted the WeatherGod:errorbar_capthick branch Jul 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment