Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the backend.qt4/5 rcparam deprecation warning in test suite. #10347

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@anntzer
Copy link
Contributor

commented Jan 30, 2018

Otherwise, the test suite is spammed by warnings. Note that pytest
explicitly disregards warnings filters (pytest issue 2430) so we can't
just set a filter when resetting the rcparams are reset in the test
suite.

The changes in matplotlib.testing are just there to allow it to be
imported relatively early in the matplotlib import process.

labeling as release critical given the amount of spam on the test suite (if this, or another similar fix, cannot be merged, then we should revert #10282 until a better solution is found).
attn @efiring who first mentioned the issue to me.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Hide the backend.qt4/5 rcparam deprecation warning in test suite.
Otherwise, the test suite is spammed by warnings.  Note that pytest
explicitly disregards warnings filters (pytest issue 2430) so we can't
just set a filter when resetting the rcparams are reset in the test
suite.

The changes in matplotlib.testing are just there to allow it to be
imported relatively early in the matplotlib import process.

@anntzer anntzer added this to the v2.2 milestone Jan 30, 2018

"The backend.qt5 rcParam was deprecated in version 2.2. In order "
"to force the use of a specific Qt5 binding, either import that "
"to force the use of a specific Qt4 binding, either import that "

This comment has been minimized.

Copy link
@jklymak

jklymak Jan 30, 2018

Contributor

Qt4->Qt5

@jklymak

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2018

I pushed a minor change

@efiring efiring merged commit 482bde0 into matplotlib:master Jan 30, 2018

3 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
lgtm analysis: Python No alert changes
Details

@anntzer anntzer deleted the anntzer:hide-backendqt-rc-warning branch Jan 30, 2018

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.