Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Move all figures to the front with a non-interactive show() in macosx backend. #1036

Merged
merged 2 commits into from

3 participants

@gellule

Previously, only the last Figure window would be moved to the front, and all other windows would stay behind the interpreter.

@WeatherGod
Collaborator

It makes sense to me, but I have absolutely zero experience with macosx backends. @mdehoon, could you comment?

@mdehoon

The patch looks good to me, but I would prefer to call the variable "window" instead of "aWindow" to be consistent with the rest of the code.

@gellule gellule Variable "window" instead of "aWindow"
to be consistent with the rest of the code.
6533674
@gellule

Here you are, variable renamed.

@mdehoon

Looks good to me. Weathergod, can you accept this pull request?

@WeatherGod
Collaborator

Will do.

@WeatherGod WeatherGod merged commit 068cad2 into matplotlib:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 23, 2012
  1. @gellule
Commits on Jul 28, 2012
  1. @gellule

    Variable "window" instead of "aWindow"

    gellule authored
    to be consistent with the rest of the code.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 0 deletions.
  1. +3 −0  src/_macosx.m
View
3  src/_macosx.m
@@ -5743,6 +5743,9 @@ - (int)index
if(nwin > 0)
{
[NSApp activateIgnoringOtherApps: YES];
+ for (NSWindow *window in [NSApp windows]) {
+ [window orderFront:nil];
+ }
[NSApp run];
}
Py_INCREF(Py_None);
Something went wrong with that request. Please try again.