Skip to content
This repository

Move all figures to the front with a non-interactive show() in macosx backend. #1036

Merged
merged 2 commits into from over 1 year ago

3 participants

gellule Benjamin Root mdehoon
gellule

Previously, only the last Figure window would be moved to the front, and all other windows would stay behind the interpreter.

Benjamin Root
Collaborator

It makes sense to me, but I have absolutely zero experience with macosx backends. @mdehoon, could you comment?

mdehoon

The patch looks good to me, but I would prefer to call the variable "window" instead of "aWindow" to be consistent with the rest of the code.

gellule Variable "window" instead of "aWindow"
to be consistent with the rest of the code.
6533674
gellule

Here you are, variable renamed.

mdehoon

Looks good to me. Weathergod, can you accept this pull request?

Benjamin Root
Collaborator

Will do.

Benjamin Root WeatherGod merged commit 068cad2 into from
Benjamin Root WeatherGod closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 2 unique commits by 1 author.

Jul 23, 2012
gellule Move all figures to the front with a non-interactive show() in macosx…
… backend.
0c8bee7
Jul 27, 2012
gellule Variable "window" instead of "aWindow"
to be consistent with the rest of the code.
6533674
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 3 additions and 0 deletions. Show diff stats Hide diff stats

  1. 3  src/_macosx.m
3  src/_macosx.m
@@ -5743,6 +5743,9 @@ - (int)index
5743 5743
     if(nwin > 0)
5744 5744
     {
5745 5745
         [NSApp activateIgnoringOtherApps: YES];
  5746
+        for (NSWindow *window in [NSApp windows]) {
  5747
+            [window orderFront:nil];
  5748
+        }
5746 5749
         [NSApp run];
5747 5750
     }
5748 5751
     Py_INCREF(Py_None);
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.