Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused _is_list_like. Move six import up. #10409

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
None yet
3 participants
@anntzer
Copy link
Contributor

commented Feb 10, 2018

PR Summary

noted in #10389 (comment)

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Testing label Feb 10, 2018

@@ -1,19 +1,15 @@
from __future__ import (absolute_import, division, print_function,
unicode_literals)

import six

This comment has been minimized.

Copy link
@QuLogic

QuLogic Feb 10, 2018

Member

Not needed in this file any more.

This comment has been minimized.

Copy link
@tacaswell

tacaswell Feb 10, 2018

Member

They are all going away soon anyway so 🤷‍♂

@tacaswell tacaswell added this to the v2.2 milestone Feb 10, 2018

@QuLogic QuLogic merged commit d7af676 into matplotlib:master Feb 10, 2018

8 checks passed

ci/circleci: docs-python27 Your tests passed on CircleCI!
Details
ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project/library 67.26% (target 50%)
Details
codecov/project/tests 98.64% remains the same compared to 83d614b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@anntzer anntzer deleted the anntzer:remove-unused-private branch Feb 10, 2018

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.