Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove sphinx markup that confsed SG #10460

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants

@phobson phobson added this to the v2.2-doc milestone Feb 14, 2018

@dstansby
Copy link
Contributor

left a comment

👍 when CI passes

@phobson

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2018

@dstansby thanks. Will you squash/merge to fix the typo in my commit message (confsed -> confused) 👼

@@ -24,7 +24,7 @@
# Fernando Perez has provided a nice top level method to create in
# :func:`~matplotlib.pyplots.subplots` (note the "s" at the end)
# everything at once, and turn on x and y sharing for the whole bunch.
# You can either unpack the axes individually::
# You can either unpack the axes individually.

This comment has been minimized.

Copy link
@dopplershift

dopplershift Feb 14, 2018

Contributor

While you're cleaning this up...any chance to make that an actual sentence--or make some semblance of sense?

This comment has been minimized.

Copy link
@dopplershift

dopplershift Feb 14, 2018

Contributor

Oh, I see now...probably should end in "..." to indicate the continuation coming later.

@QuLogic QuLogic force-pushed the phobson:doc-quick-subplots-fix branch from 2972982 to cf8bad6 Feb 14, 2018

@QuLogic

This comment has been minimized.

Copy link
Member

commented Feb 14, 2018

I pushed an update with the typos corrected.

@phobson

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2018

thanks @QuLogic

@QuLogic QuLogic merged commit 3d929fc into matplotlib:master Feb 15, 2018

8 checks passed

ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
ci/circleci: docs-python36 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 89647c1...cf8bad6
Details
codecov/project/library 66.95% (target 50%)
Details
codecov/project/tests 98.39% remains the same compared to 89647c1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

meeseeksdev bot pushed a commit that referenced this pull request Feb 15, 2018

@phobson phobson deleted the phobson:doc-quick-subplots-fix branch Feb 15, 2018

dstansby added a commit that referenced this pull request Feb 15, 2018

@QuLogic QuLogic modified the milestones: v2.2-doc, v2.2.0 Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.