Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: DPI inconsistency of draggable legend #10469

Merged
merged 2 commits into from Feb 16, 2018

Conversation

Projects
None yet
3 participants
@afvincent
Copy link
Contributor

commented Feb 15, 2018

PR Summary

Fix for #10458 : draggable legend has an inconsistent offset behavior between the DPI value used for display and the DPI value used for saving. This was introduced in 199a87a due to some refactoring that was just a bit too eager. This PR simply reverts the one line that is causing the issue, and fixes some typos in a related docstring. Please see #10458 for more details about the issue (bisect, manual test script, etc.).

As the side remark, this issue was silently introduced because it affects an interactive part of Matplotlib, thus that it is not exercised by the test suite (if I a remember correctly).

PR Checklist

  • Has Pytest style unit tests: no, as this is related to interactive behavior.
  • Code is PEP 8 compliant: fingers crossed 馃悜

@afvincent afvincent added this to the v2.2.0 milestone Feb 15, 2018

@afvincent afvincent requested review from tacaswell and anntzer Feb 15, 2018

@dstansby dstansby merged commit 656ef67 into matplotlib:master Feb 16, 2018

8 checks passed

ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
ci/circleci: docs-python36 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project/library 66.95% (target 50%)
Details
codecov/project/tests 98.39% (+0.04%) compared to 3d929fc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

meeseeksdev bot pushed a commit that referenced this pull request Feb 16, 2018

dstansby added a commit that referenced this pull request Feb 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.