Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Enable building on Python 3.3 for Windows #1047

Merged
merged 1 commit into from

2 participants

@cgohlke

No description provided.

@pelson
Collaborator

@cgohlke do you think we should just get rid of the upper bound?

@cgohlke

@pelson: I presume a future version of Python (3.4 or 3.5?) will use Tcl/Tk 8.6. In that case it is probably better for the build to fail than linking to a wrong version.

@pelson
Collaborator

thanks for the info. will merge this evening (in 10hrs) to give others a chance to read the diff.

@pelson pelson merged commit 7e14561 into matplotlib:master
@pelson
Collaborator

Thanks again @cgohlke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 29, 2012
  1. @cgohlke
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  setupext.py
View
2  setupext.py
@@ -942,7 +942,7 @@ def add_tk_flags(module):
message = None
if sys.platform == 'win32':
major, minor1, minor2, s, tmp = sys.version_info
- if (2, 6) <= (major, minor1) <= (3, 2):
+ if (2, 6) <= (major, minor1) <= (3, 3):
module.include_dirs.extend(['win32_static/include/tcl85'])
module.libraries.extend(['tk85', 'tcl85'])
elif major == 2 and minor1 in [3, 4, 5]:
Something went wrong with that request. Please try again.