Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize cbook.get_realpath_and_stat. #10534

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
4 participants
@anntzer
Copy link
Contributor

commented Feb 19, 2018

st_ino has been implemented in Windows for a while
(https://hg.python.org/cpython/rev/9cd1036455e7).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the anntzer:getrealpathandstat branch from 0918700 to 19e36d7 Feb 19, 2018

- ``mathtext.unichr_safe`` (use ``chr`` instead)
The following functions and classes are deprecated:

- ``cbook.GetRealpathAndStat`` (which is a only helper for

This comment has been minimized.

Copy link
@dstansby

dstansby Feb 19, 2018

Contributor

"a only" --> "only a"?

This comment has been minimized.

Copy link
@anntzer

anntzer Feb 19, 2018

Author Contributor

untypoed

Modernize cbook.get_realpath_and_stat.
st_ino has been implemented in Windows for a while
(https://hg.python.org/cpython/rev/9cd1036455e7).

@anntzer anntzer force-pushed the anntzer:getrealpathandstat branch from 19e36d7 to d7bdc0f Feb 19, 2018

@tacaswell tacaswell added this to the v3.0 milestone Feb 19, 2018

@efiring efiring merged commit 180639b into matplotlib:master Feb 19, 2018

8 checks passed

ci/circleci: docs-python35 Your tests passed on CircleCI!
Details
ci/circleci: docs-python36 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project/library 67.03% (target 50%)
Details
codecov/project/tests 98.39% remains the same compared to f1f83f6
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@anntzer anntzer deleted the anntzer:getrealpathandstat branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.